aboutsummaryrefslogtreecommitdiff
path: root/daemon
diff options
context:
space:
mode:
authorEric Blake <eblake@redhat.com>2012-01-02 14:35:12 -0700
committerEric Blake <eblake@redhat.com>2012-01-02 14:35:12 -0700
commit269ce467fc76dbd1a75c9e982d4cba1f0ba36fc2 (patch)
tree10574ef346b66480cdb93e8c4bf1593d6c1e6e01 /daemon
parentvirsh: Fix checking for reconnect conditions (diff)
downloadlibvirt-269ce467fc76dbd1a75c9e982d4cba1f0ba36fc2.tar.gz
libvirt-269ce467fc76dbd1a75c9e982d4cba1f0ba36fc2.tar.bz2
libvirt-269ce467fc76dbd1a75c9e982d4cba1f0ba36fc2.zip
domiftune: clean up previous patches
Most severe here is a latent (but currently untriggered) memory leak if any hypervisor ever adds a string interface property; the remainder are mainly cosmetic. * include/libvirt/libvirt.h.in (VIR_DOMAIN_BANDWIDTH_*): Move macros closer to interface that uses them, and document type. * src/libvirt.c (virDomainSetInterfaceParameters) (virDomainGetInterfaceParameters): Formatting tweaks. * daemon/remote.c (remoteDispatchDomainGetInterfaceParameters): Avoid memory leak. * src/libvirt_public.syms (LIBVIRT_0.9.9): Sort lines. * src/libvirt_private.syms (domain_conf.h): Likewise. * src/qemu/qemu_driver.c (qemuDomainSetInterfaceParameters): Fix comments, break long lines.
Diffstat (limited to 'daemon')
-rw-r--r--daemon/remote.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/daemon/remote.c b/daemon/remote.c
index b7ba32198..a28a75403 100644
--- a/daemon/remote.c
+++ b/daemon/remote.c
@@ -1,7 +1,7 @@
/*
* remote.c: handlers for RPC method calls
*
- * Copyright (C) 2007-2011 Red Hat, Inc.
+ * Copyright (C) 2007-2012 Red Hat, Inc.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
@@ -3495,9 +3495,10 @@ success:
cleanup:
if (rv < 0)
virNetMessageSaveError(rerr);
+ virTypedParameterArrayClear(params, nparams);
+ VIR_FREE(params);
if (dom)
virDomainFree(dom);
- VIR_FREE(params);
return rv;
}