diff options
| author |   Zac Medico <zmedico@gentoo.org> | 2009-10-18 00:23:05 +0000 |
|---|---|---|
| committer | Zac Medico <zmedico@gentoo.org> | 2009-10-18 00:23:05 +0000 |
| commit | 4db9b69b55539bea618bf5383a5cd86265323fb7 (patch) | |
| tree | 26302318d2076a4c2aff6a3d20dce93d64b2d4db /bin | |
| parent | Make cpv_getkey() use catpkgsplit() insead of a separate regex. (diff) | |
| download | portage-idfetch-4db9b69b55539bea618bf5383a5cd86265323fb7.tar.gz portage-idfetch-4db9b69b55539bea618bf5383a5cd86265323fb7.tar.bz2 portage-idfetch-4db9b69b55539bea618bf5383a5cd86265323fb7.zip | |
Bug #227225 - Add *DEPEND.badtilde warning for ~ operator used with non-zero
revision. Thanks to David Leverton <levertond@googlemail.com> for this patch.
svn path=/main/trunk/; revision=14629
Diffstat (limited to 'bin')
| -rwxr-xr-x | bin/repoman | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/bin/repoman b/bin/repoman index c764aed7..bfd13669 100755 --- a/bin/repoman +++ b/bin/repoman @@ -295,6 +295,9 @@ qahelp={ "DEPEND.syntax":"Syntax error in DEPEND (usually an extra/missing space/parenthesis)", "RDEPEND.syntax":"Syntax error in RDEPEND (usually an extra/missing space/parenthesis)", "PDEPEND.syntax":"Syntax error in PDEPEND (usually an extra/missing space/parenthesis)", + "DEPEND.badtilde":"DEPEND uses the ~ dep operator with a non-zero revision part, which is useless (the revision is ignored)", + "RDEPEND.badtilde":"RDEPEND uses the ~ dep operator with a non-zero revision part, which is useless (the revision is ignored)", + "PDEPEND.badtilde":"PDEPEND uses the ~ dep operator with a non-zero revision part, which is useless (the revision is ignored)", "LICENSE.syntax":"Syntax error in LICENSE (usually an extra/missing space/parenthesis)", "PROVIDE.syntax":"Syntax error in PROVIDE (usually an extra/missing space/parenthesis)", "PROPERTIES.syntax":"Syntax error in PROPERTIES (usually an extra/missing space/parenthesis)", @@ -349,6 +352,7 @@ qawarnings = set(( "DEPEND.badmasked","RDEPEND.badmasked","PDEPEND.badmasked", "DEPEND.badindev","RDEPEND.badindev","PDEPEND.badindev", "DEPEND.badmaskedindev","RDEPEND.badmaskedindev","PDEPEND.badmaskedindev", +"DEPEND.badtilde", "RDEPEND.badtilde", "PDEPEND.badtilde", "DESCRIPTION.toolong", "KEYWORDS.dropped", "KEYWORDS.stupid", @@ -1502,6 +1506,14 @@ for x in scanlist: " not supported with EAPI='%s':" + \ " '%s'") % (mytype, eapi, atom)) + if atom.operator == "~" and \ + portage.versions.catpkgsplit(atom.cpv)[3] != "r0": + stats[mytype + '.badtilde'] += 1 + fails[mytype + '.badtilde'].append( + (relative_path + ": %s uses the ~ operator" + " with a non-zero revision:" + \ + " '%s'") % (mytype, atom)) + type_list.extend([mytype] * (len(badsyntax) - len(type_list))) for m,b in zip(type_list, badsyntax): |