diff options
| author |   Alec Warner <antarus@gentoo.org> | 2007-01-08 23:47:44 +0000 |
|---|---|---|
| committer | Alec Warner <antarus@gentoo.org> | 2007-01-08 23:47:44 +0000 |
| commit | 64715f30c51de3df872ead203eadae78409d1f90 (patch) | |
| tree | 669e708b4980ff2c0938578a104d3d892826ff61 /bin/ebuild.sh | |
| parent | Implement QA checks that attempt to detect changed shopts and IFS in ebuild/e... (diff) | |
| download | portage-multirepo-64715f30c51de3df872ead203eadae78409d1f90.tar.gz portage-multirepo-64715f30c51de3df872ead203eadae78409d1f90.tar.bz2 portage-multirepo-64715f30c51de3df872ead203eadae78409d1f90.zip | |
Antarus sucks at bash, thanks for Genone for reporting this major bug.
svn path=/main/trunk/; revision=5485
Diffstat (limited to 'bin/ebuild.sh')
| -rwxr-xr-x | bin/ebuild.sh | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/bin/ebuild.sh b/bin/ebuild.sh index 88253dc5..1a938168 100755 --- a/bin/ebuild.sh +++ b/bin/ebuild.sh @@ -21,7 +21,7 @@ declare -rx EBUILD_PHASE # These two functions wrap sourcing and calling respectively. At present they # perform a qa check to make sure eclasses and ebuilds and profiles don't mess # with shell opts (shopts). Ebuilds/eclasses changing shopts should reset them -# when they are done. +# when they are done. Note: For now these shoudl always return success. qa_source() { local shopts=$(shopt) OLDIFS="$IFS" @@ -30,6 +30,7 @@ qa_source() { vecho "QA Notice: Global shell options were changed and not restored while sourcing $1" [[ "$IFS" != "$OLDIFS" ]] && vecho "QA Notice: IFS was changed and not reset while sourcing $1" + return 0 } qa_call() { @@ -39,6 +40,7 @@ qa_call() { vecho "QA Notice: Global shell options were changed while calling $1" [[ "$IFS" != "$OLDIFS" ]] && vecho "QA Notice: IFS was changed and not reset while calling $1" + return 0 } if [ "$*" != "depend" ] && [ "$*" != "clean" ] && [ "$*" != "nofetch" ]; then |