From 03b1ed2f3e1af3a6f64c6e9b51b073a81d1b9789 Mon Sep 17 00:00:00 2001 From: Zac Medico Date: Sat, 7 Jun 2008 22:07:21 +0000 Subject: As suggested by Flameeyes, add a new 'inherit.autotools' check which warns when autotools has been inherited but none of the eautomake, eautoconf or eautoreconf functions are called like they are supposed to be. svn path=/main/trunk/; revision=10592 --- bin/repoman | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'bin') diff --git a/bin/repoman b/bin/repoman index cf8047ea..3cabe0a7 100755 --- a/bin/repoman +++ b/bin/repoman @@ -255,6 +255,7 @@ qahelp={ "file.size":"Files in the files directory must be under 20k", "file.name":"File/dir name must be composed of only the following chars: %s " % allowed_filename_chars, "file.UTF8":"File is not UTF8 compliant", + "inherit.autotools":"Ebuild inherits autotools but does not call eautomake, eautoconf or eautoreconf", "java.eclassesnotused":"With virtual/jdk in DEPEND you must inherit a java eclass", "KEYWORDS.dropped":"Ebuilds that appear to have dropped KEYWORDS for some arch", "KEYWORDS.missing":"Ebuilds that have a missing or empty KEYWORDS variable", @@ -335,6 +336,7 @@ qawarnings=[ "ebuild.badheader", "ebuild.patches", "file.size", +"inherit.autotools", "java.eclassesnotused", "metadata.missing", "metadata.bad", @@ -1073,7 +1075,7 @@ for x in scanlist: myaux = ebuild_metadata[y] eapi = myaux["EAPI"] - inherited = myaux["INHERITED"].split() + inherited = frozenset(myaux["INHERITED"].split()) # Test for negative logic and bad words in the RESTRICT var. #for x in myaux[allvars.index("RESTRICT")].split(): @@ -1381,7 +1383,8 @@ for x in scanlist: full_path = os.path.join(repodir, relative_path) f = open(full_path, 'rb') try: - for check_name, e in run_checks(f, os.stat(full_path).st_mtime): + for check_name, e in run_checks(f, os.stat(full_path).st_mtime, + inherited=inherited): stats[check_name] += 1 fails[check_name].append(relative_path + ': %s' % e) finally: -- cgit v1.2.3-65-gdbad