diff options
| author |   Ulrich Müller <ulm@gentoo.org> | 2017-04-15 11:11:18 +0200 |
|---|---|---|
| committer | Ulrich Müller <ulm@gentoo.org> | 2017-04-20 19:20:04 +0200 |
| commit | c40c39537d584f57e449d3525e92fafbe85517fd (patch) | |
| tree | 14902f7d7ff5be78980843eb579437f88820f168 | |
| parent | Prevent crash if os.nice() fails (diff) | |
| download | portage-c40c39537d584f57e449d3525e92fafbe85517fd.tar.gz portage-c40c39537d584f57e449d3525e92fafbe85517fd.tar.bz2 portage-c40c39537d584f57e449d3525e92fafbe85517fd.zip | |
dosym: Make implicit basename a fatal error.
The respective QA warning in the dosym helper is in place since 2011.
All known violations in the gentoo repository have been fixed.
Gentoo-Bug: 379899
Acked-by: Brian Dolbec <dolsen@gentoo.org>
| -rwxr-xr-x | bin/ebuild-helpers/dosym | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/bin/ebuild-helpers/dosym b/bin/ebuild-helpers/dosym index 0bc8cc7be..b9c70ce9c 100755 --- a/bin/ebuild-helpers/dosym +++ b/bin/ebuild-helpers/dosym @@ -1,5 +1,5 @@ #!/bin/bash -# Copyright 1999-2012 Gentoo Foundation +# Copyright 1999-2017 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 source "${PORTAGE_BIN_PATH}"/isolated-functions.sh || exit 1 @@ -13,10 +13,9 @@ if ! ___eapi_has_prefix_variables; then ED=${D} fi -if [[ ${2} == */ ]] || \ - [[ -d ${ED}${2} && ! -L ${ED}${2} ]] ; then +if [[ ${2} == */ ]] || [[ -d ${ED}${2} && ! -L ${ED}${2} ]] ; then # implicit basename not allowed by PMS (bug #379899) - eqawarn "QA Notice: dosym target omits basename: '${2}'" + __helpers_die "${0##*/}: dosym target omits basename: '${2}'" fi destdir=${2%/*} |