aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKevin Wolf <kwolf@redhat.com>2010-04-21 11:37:52 +0200
committerDoug Goldstein <cardoe@gentoo.org>2010-07-20 17:39:45 -0500
commit827dccd6740639c64732418539bf17e6e4c99d77 (patch)
treedb4e8cbef961a324a77c903c3e437fc622db1583
parentvmdk: Fix COW (diff)
downloadqemu-kvm-827dccd6740639c64732418539bf17e6e4c99d77.tar.gz
qemu-kvm-827dccd6740639c64732418539bf17e6e4c99d77.tar.bz2
qemu-kvm-827dccd6740639c64732418539bf17e6e4c99d77.zip
qcow2: Remove abort on free_clusters failure
While it's true that during regular operation free_clusters failure would be a bug, an I/O error can always happen. There's no need to kill the VM, the worst thing that can happen (and it will) is that we leak some clusters. Signed-off-by: Kevin Wolf <kwolf@redhat.com> (cherry picked from commit 003fad6e2cae5311d3aea996388c90e3ab17de90)
-rw-r--r--block/qcow2-refcount.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 465d5d36e..ff2cf6db2 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -631,7 +631,7 @@ void qcow2_free_clusters(BlockDriverState *bs,
ret = update_refcount(bs, offset, size, -1);
if (ret < 0) {
fprintf(stderr, "qcow2_free_clusters failed: %s\n", strerror(-ret));
- abort();
+ /* TODO Remember the clusters to free them later and avoid leaking */
}
}