From 87b7dfe2ebd17f8cc85626aeacef115505b709ae Mon Sep 17 00:00:00 2001 From: Avi Kivity Date: Sun, 16 May 2010 14:59:57 +0300 Subject: block: fix aio_flush segfaults for read-only protocols (e.g. curl) Not all block format drivers expose an io_flush method (reasonable for read-only protocols), so calling io_flush there will immediately segfault. Fix by checking for the method's existence before calling it. Signed-off-by: Avi Kivity Signed-off-by: Kevin Wolf (cherry picked from commit c53a7285b4377e91f30b7742c7e12c16d6bf86f0) --- aio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/aio.c b/aio.c index f164a478c..2f086557b 100644 --- a/aio.c +++ b/aio.c @@ -113,7 +113,9 @@ void qemu_aio_flush(void) qemu_aio_wait(); QLIST_FOREACH(node, &aio_handlers, node) { - ret |= node->io_flush(node->opaque); + if (node->io_flush) { + ret |= node->io_flush(node->opaque); + } } } while (qemu_bh_poll() || ret > 0); } -- cgit v1.2.3-65-gdbad