summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndreas Sturmlechner <asturm@gentoo.org>2018-12-01 19:39:52 +0100
committerAndreas Sturmlechner <asturm@gentoo.org>2018-12-01 20:20:32 +0100
commitbeb6ed08d4fbd0d732510a629faf8faeefb49f01 (patch)
tree8f7bb6fd6e020f566dfed6ca4ac76c56b1b22b78 /kde-apps/dolphin/files
parentkde-plasma: Drop KDE Plasma 5.13.5 (diff)
downloadgentoo-beb6ed08d4fbd0d732510a629faf8faeefb49f01.tar.gz
gentoo-beb6ed08d4fbd0d732510a629faf8faeefb49f01.tar.bz2
gentoo-beb6ed08d4fbd0d732510a629faf8faeefb49f01.zip
kde-apps: Drop KDE Applications 18.04.3
Package-Manager: Portage-2.3.52, Repoman-2.3.12 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Diffstat (limited to 'kde-apps/dolphin/files')
-rw-r--r--kde-apps/dolphin/files/dolphin-18.04.3-memleak-1.patch36
-rw-r--r--kde-apps/dolphin/files/dolphin-18.04.3-memleak-2.patch37
-rw-r--r--kde-apps/dolphin/files/dolphin-18.04.3-root-user.patch56
-rw-r--r--kde-apps/dolphin/files/dolphin-18.04.3-root-warn.patch45
4 files changed, 0 insertions, 174 deletions
diff --git a/kde-apps/dolphin/files/dolphin-18.04.3-memleak-1.patch b/kde-apps/dolphin/files/dolphin-18.04.3-memleak-1.patch
deleted file mode 100644
index 5bbeaa7e617..00000000000
--- a/kde-apps/dolphin/files/dolphin-18.04.3-memleak-1.patch
+++ /dev/null
@@ -1,36 +0,0 @@
-From 4536e25ac929d8d37ffbbba0642de662bcc9f891 Mon Sep 17 00:00:00 2001
-From: David Hallas <david@davidhallas.dk>
-Date: Wed, 18 Jul 2018 23:20:18 +0200
-Subject: Fixes memory leak in KItemListViewAccessible
-
-Summary: The KItemListViewAccessible class has a list of QAccessibleInterface pointers in a member variable m_cells. The problem is that when new entries are created, the newly allocated pointer is not stored in the list, only a nullptr is store, this renders the cleanup code in the destructor useless. This patch simply stores the pointer in the list, causing the destructor to correctly free the memory.
-
-Test Plan: I found this issue using address sanitizer. Simply building Dolphin with -fsanitize=address and opening a window caused the memory leak.
-
-Reviewers: #dolphin, jtamate, elvisangelaccio
-
-Reviewed By: #dolphin, jtamate, elvisangelaccio
-
-Subscribers: elvisangelaccio, kfm-devel
-
-Tags: #dolphin
-
-Differential Revision: https://phabricator.kde.org/D14168
----
- src/kitemviews/kitemlistviewaccessible.cpp | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/src/kitemviews/kitemlistviewaccessible.cpp b/src/kitemviews/kitemlistviewaccessible.cpp
-index 69c126f..4d1b28b 100644
---- a/src/kitemviews/kitemlistviewaccessible.cpp
-+++ b/src/kitemviews/kitemlistviewaccessible.cpp
-@@ -78,6 +78,7 @@ QAccessibleInterface* KItemListViewAccessible::cell(int index) const
- QAccessibleInterface* child = m_cells.at(index);
- if (!child) {
- child = new KItemListAccessibleCell(view(), index);
-+ m_cells.insert(index, child);
- QAccessible::registerAccessibleInterface(child);
- }
- return child;
---
-cgit v0.11.2
diff --git a/kde-apps/dolphin/files/dolphin-18.04.3-memleak-2.patch b/kde-apps/dolphin/files/dolphin-18.04.3-memleak-2.patch
deleted file mode 100644
index f39885bdca3..00000000000
--- a/kde-apps/dolphin/files/dolphin-18.04.3-memleak-2.patch
+++ /dev/null
@@ -1,37 +0,0 @@
-From 2cbf3cb11ea668577121fa755c1ddacc6f0acdd8 Mon Sep 17 00:00:00 2001
-From: David Hallas <david@davidhallas.dk>
-Date: Wed, 18 Jul 2018 16:43:25 -0600
-Subject: Fixes small memory leak in DolphinContextMenu
-
-Summary: When DolphinContextMenu::baseFileItem is called a KFileItem is allocated and stored in DolphinContextMenu::m_baseFileItem, which is of type KFileItem*, but the destructor failed to delete this.
-
-Test Plan: This leak was found using Address Sanitizer
-
-Reviewers: broulik, elvisangelaccio
-
-Reviewed By: broulik, elvisangelaccio
-
-Subscribers: ngraham, kfm-devel
-
-Tags: #dolphin
-
-Differential Revision: https://phabricator.kde.org/D14178
----
- src/dolphincontextmenu.cpp | 2 ++
- 1 file changed, 2 insertions(+)
-
-diff --git a/src/dolphincontextmenu.cpp b/src/dolphincontextmenu.cpp
-index 7d7d7a4..8fdaab1 100644
---- a/src/dolphincontextmenu.cpp
-+++ b/src/dolphincontextmenu.cpp
-@@ -81,6 +81,8 @@ DolphinContextMenu::DolphinContextMenu(DolphinMainWindow* parent,
-
- DolphinContextMenu::~DolphinContextMenu()
- {
-+ delete m_baseFileItem;
-+ m_baseFileItem = nullptr;
- delete m_selectedItemsProperties;
- m_selectedItemsProperties = nullptr;
- }
---
-cgit v0.11.2
diff --git a/kde-apps/dolphin/files/dolphin-18.04.3-root-user.patch b/kde-apps/dolphin/files/dolphin-18.04.3-root-user.patch
deleted file mode 100644
index 04baafa1d8e..00000000000
--- a/kde-apps/dolphin/files/dolphin-18.04.3-root-user.patch
+++ /dev/null
@@ -1,56 +0,0 @@
-From 40453cb627a39f1ff92373f865426f0bcdc83419 Mon Sep 17 00:00:00 2001
-From: Nathaniel Graham <nate@kde.org>
-Date: Wed, 9 May 2018 17:18:08 -0600
-Subject: Re-allow running Dolphin as the root user (but still not using sudo)
-
-Summary:
-Prohibiting the use of Dolphin as the actual root user (not using `sudo` or `kdesu`) breaks legitimate use cases for using the root user. An example is Kali, a distro that logs in as the root user by default as a deliberate design choice.
-
-In such an environment, there is no additional security vulnerability beyond what you're already potentially exposing yourself to. So, let's re-enable it.
-
-BUG: 387974
-FIXED-IN: 18.08.0
-
-Test Plan:
-- Log in as normal user and run `sudo dolphin`: you get an error message.
-- Log in as normal user and run `kdesu dolphin`: you get an error message.
-- Log in as the root user and run dolphin normally: it works.
-
-Reviewers: markg, elvisangelaccio, #dolphin
-
-Reviewed By: markg
-
-Subscribers: chinmoyr, cfeck, elvisangelaccio, mmustac, Fuchs, markg, graesslin, nicolasfella, zzag, kfm-devel, emmanuelp
-
-Tags: #dolphin
-
-Differential Revision: https://phabricator.kde.org/D12795
----
- src/main.cpp | 11 ++++++++---
- 1 file changed, 8 insertions(+), 3 deletions(-)
-
-diff --git a/src/main.cpp b/src/main.cpp
-index db52e11..75bab67 100644
---- a/src/main.cpp
-+++ b/src/main.cpp
-@@ -43,10 +43,15 @@
- extern "C" Q_DECL_EXPORT int kdemain(int argc, char **argv)
- {
- #ifndef Q_OS_WIN
-- // Check whether we are running as root
-+ // Prohibit using sudo or kdesu (but allow using the root user directly)
- if (getuid() == 0) {
-- std::cout << "Executing Dolphin as root is not possible." << std::endl;
-- return EXIT_FAILURE;
-+ if (!qEnvironmentVariableIsEmpty("SUDO_USER")) {
-+ std::cout << "Executing Dolphin with sudo is not possible due to unfixable security vulnerabilities." << std::endl;
-+ return EXIT_FAILURE;
-+ } else if (!qEnvironmentVariableIsEmpty("KDESU_USER")) {
-+ std::cout << "Executing Dolphin with kdesu is not possible due to unfixable security vulnerabilities." << std::endl;
-+ return EXIT_FAILURE;
-+ }
- }
- #endif
-
---
-cgit v0.11.2
diff --git a/kde-apps/dolphin/files/dolphin-18.04.3-root-warn.patch b/kde-apps/dolphin/files/dolphin-18.04.3-root-warn.patch
deleted file mode 100644
index bd6e2ab0d81..00000000000
--- a/kde-apps/dolphin/files/dolphin-18.04.3-root-warn.patch
+++ /dev/null
@@ -1,45 +0,0 @@
-From 621cd24acfec8cbed19e9aa6ff8650cd6f38f809 Mon Sep 17 00:00:00 2001
-From: Nathaniel Graham <nate@kde.org>
-Date: Sun, 6 May 2018 17:48:54 -0600
-Subject: Show a warning when running as the root user
-
-Summary: Now that Dolphin can be run as the root user again, let's show a warning.
-
-Test Plan:
-When run with the root user account:
-{F5882057}
-
-Reviewers: #dolphin, markg, elvisangelaccio
-
-Reviewed By: markg, elvisangelaccio
-
-Subscribers: acooligan, anthonyfieroni, chinmoyr, kfm-devel, rikmills, emmanuelp, zzag, nicolasfella, elvisangelaccio, Fuchs, mmustac, markg
-
-Tags: #dolphin
-
-Differential Revision: https://phabricator.kde.org/D12732
----
- src/dolphinviewcontainer.cpp | 8 ++++++++
- 1 file changed, 8 insertions(+)
-
-diff --git a/src/dolphinviewcontainer.cpp b/src/dolphinviewcontainer.cpp
-index bf8ac88..7b99595 100644
---- a/src/dolphinviewcontainer.cpp
-+++ b/src/dolphinviewcontainer.cpp
-@@ -108,6 +108,14 @@ DolphinViewContainer::DolphinViewContainer(const QUrl& url, QWidget* parent) :
- m_messageWidget->setCloseButtonVisible(true);
- m_messageWidget->hide();
-
-+#ifndef Q_OS_WIN
-+ if (getuid() == 0) {
-+
-+ // We must be logged in as the root user; show a big scary warning
-+ showMessage(i18n("Running Dolphin as root can be dangerous. Please be careful."), Warning);
-+ }
-+#endif
-+
- m_view = new DolphinView(url, this);
- connect(m_view, &DolphinView::urlChanged,
- m_urlNavigator, &KUrlNavigator::setLocationUrl);
---
-cgit v0.11.2