From b9c4e4272bace02805880b798f8ae8637737c840 Mon Sep 17 00:00:00 2001 From: Michał Górny Date: Mon, 2 Aug 2021 10:15:24 +0200 Subject: install-qa-check.d: Switch DUS entry point check to pure bdepend MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Michał Górny --- metadata/install-qa-check.d/60distutils-use-setuptools | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) (limited to 'metadata') diff --git a/metadata/install-qa-check.d/60distutils-use-setuptools b/metadata/install-qa-check.d/60distutils-use-setuptools index 25300fddda90..a7905c3f0b2f 100644 --- a/metadata/install-qa-check.d/60distutils-use-setuptools +++ b/metadata/install-qa-check.d/60distutils-use-setuptools @@ -68,18 +68,12 @@ distutils_use_setuptools_check() { [[ ${#expected[@]} -eq 0 ]] && expected=( no ) # *+rdepend=rdepend has rdepend "${expected[@]}" && expected=( rdepend ) - - if has entry-point "${expected[@]}"; then - if [[ ${DISTUTILS_STRICT_ENTRY_POINTS} ]]; then - # option for devs to future-proof their packages - # please don't let ago enable it - expected=( bdepend ) - else - # accept either rdepend or bdepend for the time being - # but suggest bdepend as the future-proof option - expected=( bdepend rdepend ) - fi - fi + # NB: note that expected is overwritten above, so this implies !rdepend + # if the package is using entry points, modern versions of setuptools + # use built-in importlib.metadata module, so no rdep needed anymore + # NB2: this is incorrect for pypy3.7 but we ignore this for the time + # being + has entry-point "${expected[@]}" && expected=( bdepend ) if ! has ${DISTUTILS_USE_SETUPTOOLS} "${expected[@]}"; then local def= -- cgit v1.2.3-65-gdbad