diff options
| author |   Fabian Groffen <grobian@gentoo.org> | 2018-03-23 14:16:31 +0100 |
|---|---|---|
| committer | Fabian Groffen <grobian@gentoo.org> | 2018-03-23 14:16:31 +0100 |
| commit | bf111d7d5464f8a6b3a251d3d12fe9e39357bc6e (patch) | |
| tree | bb50841005853e42bf1d60fb5045d3a253ece4d2 /qxpak.c | |
| parent | getline: fix comparison of integers of different signs (diff) | |
| download | portage-utils-bf111d7d5464f8a6b3a251d3d12fe9e39357bc6e.tar.gz portage-utils-bf111d7d5464f8a6b3a251d3d12fe9e39357bc6e.tar.bz2 portage-utils-bf111d7d5464f8a6b3a251d3d12fe9e39357bc6e.zip | |
fix signedness warnings
Diffstat (limited to 'qxpak.c')
| -rw-r--r-- | qxpak.c | 8 |
1 files changed, 5 insertions, 3 deletions
@@ -341,9 +341,11 @@ xpak_create(int dir_fd, const char *file, int argc, char **argv) if ((numfiles = scandir(argv[i], &dir, filter_hidden, alphasort)) < 0) warn("Directory '%s' is empty; skipping", argv[i]); for (fidx = 0; fidx < numfiles; ++fidx) { - int ret = snprintf(path, sizeof(path), "%s/%s", argv[i], dir[fidx]->d_name); - if (ret >= sizeof(path)) { - warn("skipping path too long: %s/%s", argv[i], dir[fidx]->d_name); + int ret = snprintf(path, sizeof(path), "%s/%s", + argv[i], dir[fidx]->d_name); + if (ret < 0 || (size_t)ret >= sizeof(path)) { + warn("skipping path too long: %s/%s", + argv[i], dir[fidx]->d_name); continue; } if (stat(path, &st) < 0) { |