diff options
author | Michał Górny <mgorny@gentoo.org> | 2017-02-23 20:08:24 +0100 |
---|---|---|
committer | Michał Górny <mgorny@gentoo.org> | 2017-03-08 08:35:35 +0100 |
commit | 57f836431666db3fd058e6f4e93f7231fcac748c (patch) | |
tree | fac73b3042a7eed56ebda8e179757f2327a1f78a /eclass/unpacker.eclass | |
parent | ruby-fakegem.eclass: Remove completely unnecessary 'eval ls' (diff) | |
download | gentoo-57f836431666db3fd058e6f4e93f7231fcac748c.tar.gz gentoo-57f836431666db3fd058e6f4e93f7231fcac748c.tar.bz2 gentoo-57f836431666db3fd058e6f4e93f7231fcac748c.zip |
ruby-ng.eclass: Replace unnecessary 'eval ls' with array fnexp
Replace the unnecessary use of 'eval ls -d ...' with much simpler
and safer filename expansion via bash array. The 'eval' was completely
unnecessary in the original code; however, the late addition of quoting
would have broken it if eval did not implicitly discard the quotes.
The 'ls -d' was unnecessary as well since bash performs filename
expansion before passing the parameter to 'ls'.
Furthermore, a check for accidental multiple expansion has been added.
A complementary check for failed expansion can not be added since
the function is called in src_unpack() as well and the expansion fails
then.
Diffstat (limited to 'eclass/unpacker.eclass')
0 files changed, 0 insertions, 0 deletions