1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
|
diff -Naur CGI-FormBuilder-3.09/t/1c-validate.t CGI-FormBuilder-3.09b/t/1c-validate.t
--- CGI-FormBuilder-3.09/t/1c-validate.t 2013-11-30 00:10:36.000000000 +0000
+++ CGI-FormBuilder-3.09b/t/1c-validate.t 2016-05-11 13:10:45.680369595 +0000
@@ -174,11 +174,11 @@
for my $t (@test) {
my $form = CGI::FormBuilder->new( %{ $t->{opt} }, debug => $DEBUG );
- while(my($f,$o) = each %{$t->{mod} || {}}) {
- $o->{name} = $f;
- $form->field(%$o);
+ for my $field ( sort keys %{ $t->{mod} || {} } ) {
+ my $object = $t->{mod}->{$field};
+ $object->{name} = $field;
+ $form->field( %{ $object } );
}
-
# just try to validate
ok($form->validate, $t->{pass} || 0);
}
diff -Naur CGI-FormBuilder-3.09/t/1d-messages.t CGI-FormBuilder-3.09b/t/1d-messages.t
--- CGI-FormBuilder-3.09/t/1d-messages.t 2013-11-30 00:10:36.000000000 +0000
+++ CGI-FormBuilder-3.09b/t/1d-messages.t 2016-05-11 13:08:33.159540213 +0000
@@ -70,8 +70,9 @@
my $locale = "fb_FAKE";
my $messages = "messages.$locale";
open(M, ">$messages") || warn "Can't write $messages: $!";
-while (my($k,$v) = each %messages) {
- print M join(' ', $k, ref($v) ? @$v : $v), "\n";
+for my $k ( sort keys %messages ) {
+ my $v = $messages{$k};
+ print M join(' ', $k, ref($v) ? @$v : $v), "\n";
}
close(M);
@@ -123,7 +124,7 @@
# Final test set is to just make sure we have all the keys for all modules
require CGI::FormBuilder::Messages::default;
my %need = CGI::FormBuilder::Messages::default->messages;
-my @keys = keys %need;
+my @keys = sort keys %need;
for my $pm (@pm) {
my($lang) = $pm =~ /([a-z]+_[A-Z]+)/;
my $skip = $lang ? undef : "skip: Can't get language from $pm";
diff -Naur CGI-FormBuilder-3.09/t/2a-template-html.t CGI-FormBuilder-3.09b/t/2a-template-html.t
--- CGI-FormBuilder-3.09/t/2a-template-html.t 2013-11-30 00:10:36.000000000 +0000
+++ CGI-FormBuilder-3.09b/t/2a-template-html.t 2016-05-11 13:11:57.438740284 +0000
@@ -102,18 +102,19 @@
my $seq = $ARGV[0] || 1;
# Cycle thru and try it out
-for (@test) {
+for my $test_item (@test) {
my $form = CGI::FormBuilder->new(
debug => $DEBUG,
action => 'TEST',
title => 'TEST',
- %{ $_->{opt} },
+ %{ $test_item->{opt} },
);
# the ${mod} key twiddles fields
- while(my($f,$o) = each %{$_->{mod} || {}}) {
- $o->{name} = $f;
- $form->field(%$o);
+ for my $field ( sort keys %{ $test_item->{mod} || {} } ) {
+ my $object = $test_item->{mod}->{$field};
+ $object->{name} = $field;
+ $form->field( %{ $object } );
}
#
diff -Naur CGI-FormBuilder-3.09/t/2b-template-text.t CGI-FormBuilder-3.09b/t/2b-template-text.t
--- CGI-FormBuilder-3.09/t/2b-template-text.t 2013-11-30 00:10:36.000000000 +0000
+++ CGI-FormBuilder-3.09b/t/2b-template-text.t 2016-05-11 13:11:29.861982062 +0000
@@ -97,18 +97,19 @@
my $seq = $ARGV[0] || 1;
# Cycle thru and try it out
-for (@test) {
+for my $test_item (@test) {
my $form = CGI::FormBuilder->new(
debug => $DEBUG,
action => 'TEST',
title => 'TEST',
- %{ $_->{opt} },
+ %{ $test_item->{opt} },
);
# the ${mod} key twiddles fields
- while(my($f,$o) = each %{$_->{mod} || {}}) {
- $o->{name} = $f;
- $form->field(%$o);
+ for my $field ( sort keys %{ $test_item->{mod} || {} } ) {
+ my $object = $test_item->{mod}->{$field};
+ $object->{name} = $field;
+ $form->field( %{ $object } );
}
#
diff -Naur CGI-FormBuilder-3.09/t/2d-template-fast.t CGI-FormBuilder-3.09b/t/2d-template-fast.t
--- CGI-FormBuilder-3.09/t/2d-template-fast.t 2013-11-30 00:10:36.000000000 +0000
+++ CGI-FormBuilder-3.09b/t/2d-template-fast.t 2016-05-11 13:15:58.497630259 +0000
@@ -135,18 +135,19 @@
my $seq = $ARGV[0] || 1;
# Cycle thru and try it out
-for (@test) {
+for my $test_item (@test) {
my $form = CGI::FormBuilder->new(
debug => $DEBUG,
action => 'TEST',
title => 'TEST',
- %{ $_->{opt} },
+ %{ $test_item->{opt} },
);
# the ${mod} key twiddles fields
- while(my($f,$o) = each %{$_->{mod} || {}}) {
- $o->{name} = $f;
- $form->field(%$o);
+ for my $field ( sort keys %{ $test_item->{mod} || {} } ) {
+ my $object = $test_item->{mod}->{$field};
+ $object->{name} = $field;
+ $form->field( %{ $object } );
}
#
diff -Naur CGI-FormBuilder-3.09/t/2e-template-ssi.t CGI-FormBuilder-3.09b/t/2e-template-ssi.t
--- CGI-FormBuilder-3.09/t/2e-template-ssi.t 2013-11-30 00:10:36.000000000 +0000
+++ CGI-FormBuilder-3.09b/t/2e-template-ssi.t 2016-05-11 13:12:37.526388964 +0000
@@ -102,18 +102,19 @@
my $seq = $ARGV[0] || 1;
# Cycle thru and try it out
-for (@test) {
+for my $test_item (@test) {
my $form = CGI::FormBuilder->new(
debug => $DEBUG,
action => 'TEST',
title => 'TEST',
- %{ $_->{opt} },
+ %{ $test_item->{opt} },
);
# the ${mod} key twiddles fields
- while(my($f,$o) = each %{$_->{mod} || {}}) {
- $o->{name} = $f;
- $form->field(%$o);
+ for my $field ( sort keys %{ $test_item->{mod} || {} } ) {
+ my $object = $test_item->{mod}->{$field};
+ $object->{name} = $field;
+ $form->field( %{ $object } );
}
#
|
GitWeb