app-crypt/mhash/files/mhash-0.9.9-fix-whirlpool-segfault.patch


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27

The package app-crypt/mhash-0.9.9 as well as app-crypt/mhash-0.9.9-r1 are
affected by a bug which causes a NULL ptr dereference in whirlpool/snefru
digest-completion functionality.

In this patch, whirlpool and snefru's code is updated to bail if 'digest' is
NULL.  The code portion aborted is only responsible for writing data to the
digest, so this appears to be correct behavior.

Patch already submitted upstream, but depending on speed, this may be faster to
patch in a new patchset.

Gentoo-Bug: 255131
Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=255131
Patch-URL: http://bugs.gentoo.org/attachment.cgi?id=178667&action=view
Signed-off-by: Thomas Harning <harningt@gmail.com>

--- mhash-0.9.9/lib/whirlpool.c	2006-01-08 03:14:47.000000000 -0500
+++ mhash-0.9.9-new/lib/whirlpool.c	2009-01-16 00:17:34.000000000 -0500
@@ -970,6 +970,8 @@
                     mutils_word8 * digest)
 {
    mutils_word32 i;
+
+   if(!digest) return;
     /*
      * return the completed message digest:
      */