sci-libs/netcdf: fix bad bash scripting leading to failed testsHEADmaster

If USE=-mpi, a file in src_test is NOT sedded to fix a bug in the file,
because the file does not exist. But this condition was incorrectly
coded.

In bash:

```
cmd1 && cmd2 || cmd3
```

is a code smell. If either of the first two commands fails, the third
command is run -- in this case, die. In other words, the first two
commands were *supposed* to be "only run cmd2 if it makes sense to".
Instead, if it "doesn't make sense to" run cmd2, the die was triggered.

A more general solution is to spec the build format to require all
commands to pass without manually `die`ing (leading to the use of &&
ceasing in general), but that is not how portage works. Either way, the
solution is using `if` as intended.

ref. https://mywiki.wooledge.org/BashGuide/TestsAndConditionals

Closes: https://bugs.gentoo.org/933136
Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Signed-off-by: Sam James <sam@gentoo.org>

0 files changed, 0 insertions, 0 deletions